X-Git-Url: https://git.llucax.com/software/bacap.git/blobdiff_plain/c5001504b6a42af8a188a7e8a530300b57431705..e61d48f0be75b93a44bc40ae39e6587103bfdb48:/bacap?ds=sidebyside

diff --git a/bacap b/bacap
index c7cdeab..976ee08 100755
--- a/bacap
+++ b/bacap
@@ -35,7 +35,7 @@ DATE_FMT="%Y-%m-%d"
 PING_CHECK=1
 
 # rsync flags to use
-RSYNC_FLAGS="-aAXHx --numeric-ids"
+RSYNC_FLAGS="-aAHSXx --numeric-ids"
 
 # rsync flags to use when in verbose mode
 RSYNC_VERBOSE_FLAGS="-v --stats"
@@ -114,7 +114,7 @@ do
 	current_dir="$host_backup_path/`readlink \"$current_link\"`"
 	extra_flags=
 	plog "-----------------------------------------------------------------"
-	plog "Backup for host $host"
+	plog "Backup for host $host started at `date '+%Y-%m-%d %H:%M:%S'`"
 	plog "-----------------------------------------------------------------"
 	plog "Source:      $src"
 	plog "Destination: $dst"
@@ -132,15 +132,33 @@ do
 		extra_flags="$extra_flags --include-from=$include"
 	plog "Running rsync..."
 	$run rsync $RSYNC_FLAGS $extra_flags \
-				--link-dest="$current_dir" $src "$dst/" ||
-		ret=$(($ret+1))
-	plog "Moving current..."
-	$run rm -f $V "$current_link" ||
+				--link-dest="$current_dir" $src "$dst/"
+	rsync_ret=$?
+	case $rsync_ret in
+		0)
+			# Normal return
+			;;
+		24)
+			# Ignore error 24 from rsync ("Partial transfer due to
+			# vanished source files") which is somewhat expected
+			# since we don't do a snapshot
+			;;
+		*)
+			# Any other error is important enough
+			ret=$(($ret+1))
+			;;
+	esac
+
+	if [ $ret -eq $saved_ret ]
+	then
+		# Only move current if rsync did not fail, to avoid dangling
+		# symlinks
+		plog "Moving current..."
+		$run rm -f $V "$current_link" ||
 		ret=$(($ret+1))
-	$run ln -s $V "$date" "$current_link" ||
+		$run ln -s $V "$date" "$current_link" ||
 		ret=$(($ret+1))
-	if [ $ret -ne $saved_ret ]
-	then
+	else
 		ERROR_HOSTS="$ERROR_HOSTS $host"
 	fi
 done