X-Git-Url: https://git.llucax.com/software/libev.git/blobdiff_plain/deff62d26ff4c1324816c04c0c6db1e4db435870..bcb5dd319c35f6c72b57f4153f08a9720eb9cd4e:/ev_poll.c

diff --git a/ev_poll.c b/ev_poll.c
index e809ddd..d609833 100644
--- a/ev_poll.c
+++ b/ev_poll.c
@@ -1,5 +1,5 @@
 /*
- * libev epoll fd activity backend
+ * libev poll fd activity backend
  *
  * Copyright (c) 2007 Marc Alexander Lehmann <libev@schmorp.de>
  * All rights reserved.
@@ -31,7 +31,7 @@
 
 #include <poll.h>
 
-static void
+void inline_size
 pollidx_init (int *base, int count)
 {
   while (count--)
@@ -46,26 +46,29 @@ poll_modify (EV_P_ int fd, int oev, int nev)
   if (oev == nev)
     return;
 
-  array_needsize (pollidxs, pollidxmax, fd + 1, pollidx_init);
+  array_needsize (int, pollidxs, pollidxmax, fd + 1, pollidx_init);
 
   idx = pollidxs [fd];
 
   if (idx < 0) /* need to allocate a new pollfd */
     {
-      idx = pollcnt++;
-      array_needsize (polls, pollmax, pollcnt, );
+      pollidxs [fd] = idx = pollcnt++;
+      array_needsize (struct pollfd, polls, pollmax, pollcnt, EMPTY2);
       polls [idx].fd = fd;
     }
 
+  assert (polls [idx].fd == fd);
+
   if (nev)
     polls [idx].events =
         (nev & EV_READ ? POLLIN : 0)
         | (nev & EV_WRITE ? POLLOUT : 0);
   else /* remove pollfd */
     {
-      if (idx < pollcnt--)
+      pollidxs [fd] = -1;
+
+      if (expect_true (idx < --pollcnt))
         {
-          pollidxs [fd] = -1;
           polls [idx] = polls [pollcnt];
           pollidxs [polls [idx].fd] = idx;
         }
@@ -76,45 +79,49 @@ static void
 poll_poll (EV_P_ ev_tstamp timeout)
 {
   int i;
-  int res = poll (polls, pollcnt, ceil (timeout * 1000.));
+  int res = poll (polls, pollcnt, (int)ceil (timeout * 1000.));
 
-  if (res < 0)
+  if (expect_false (res < 0))
     {
       if (errno == EBADF)
         fd_ebadf (EV_A);
       else if (errno == ENOMEM && !syserr_cb)
         fd_enomem (EV_A);
       else if (errno != EINTR)
-        syserr ();
+        syserr ("(libev) poll");
 
       return;
     }
 
   for (i = 0; i < pollcnt; ++i)
-    fd_event (
-      EV_A_
-      polls [i].fd,
-      (polls [i].revents & (POLLOUT | POLLERR | POLLHUP) ? EV_WRITE : 0)
-      | (polls [i].revents & (POLLIN | POLLERR | POLLHUP) ? EV_READ : 0)
-    );
+    if (expect_false (polls [i].revents & POLLNVAL))
+      fd_kill (EV_A_ polls [i].fd);
+    else
+      fd_event (
+        EV_A_
+        polls [i].fd,
+        (polls [i].revents & (POLLOUT | POLLERR | POLLHUP) ? EV_WRITE : 0)
+        | (polls [i].revents & (POLLIN | POLLERR | POLLHUP) ? EV_READ : 0)
+      );
 }
 
-static int
+int inline_size
 poll_init (EV_P_ int flags)
 {
-  method_fudge  = 1e-3; /* needed to compensate for select returning early, very conservative */
-  method_modify = poll_modify;
-  method_poll   = poll_poll;
+  backend_fudge  = 0.; /* posix says this is zero */
+  backend_modify = poll_modify;
+  backend_poll   = poll_poll;
 
   pollidxs = 0; pollidxmax = 0;
   polls    = 0; pollmax    = 0; pollcnt = 0;
 
-  return EVMETHOD_POLL;
+  return EVBACKEND_POLL;
 }
 
-static void
+void inline_size
 poll_destroy (EV_P)
 {
   ev_free (pollidxs);
   ev_free (polls);
 }
+