X-Git-Url: https://git.llucax.com/software/pymin.git/blobdiff_plain/87cf90b9cadfa4c049a96c0270ea4484d8f411f2..fbe65e123a74a532d8e603831cf35d58b9a9e03e:/pymin/procman.py diff --git a/pymin/procman.py b/pymin/procman.py index 170d290..0bfb721 100644 --- a/pymin/procman.py +++ b/pymin/procman.py @@ -26,7 +26,7 @@ class ProcessInfo: self._dont_run = False self._signal = None self._process = None - self.error_count = 0 + self._error_count = 0 def start(self): assert self.process is None self.restart() @@ -59,6 +59,9 @@ class ProcessInfo: @property def process(self): return self._process + @property + def error_count(self): + return self._error_count def __repr__(self): pid = None if self.process is not None: @@ -80,12 +83,16 @@ class ProcessManager: log.debug(u'ProcessManager.register(%s, %s, %s, %s, %s, %s, %s)', name, command, callback, persist, max_errors, args, kwargs) assert not self.has(name) - self.services[name] = ProcessInfo(name, command, callback, persist, - max_errors, args, kwargs) + pi = ProcessInfo(name, command, callback, persist, max_errors, + args, kwargs) + self.services[name] = pi + return pi def unregister(self, name): log.debug(u'ProcessManager.unregister(%s)', name) + pi = self.services[name] del self.services[name] + return pi def _call(self, pi): pi.start() @@ -99,16 +106,21 @@ class ProcessManager: pi = ProcessInfo(name, command, callback, persist, max_errors, args, kwargs) self._call(pi) + return pi def start(self, name): log.debug(u'ProcessManager.start(%s)', name) - assert name not in self.namemap - self._call(self.services[name]) + if name not in self.namemap: + self._call(self.services[name]) + return True + return False def stop(self, name): log.debug(u'ProcessManager.stop(%s)', name) - assert name in self.namemap - self.namemap[name].stop() + if name in self.namemap: + self.namemap[name].stop() + return True + return False def restart(self, name): log.debug(u'ProcessManager.restart(%s)', name) @@ -116,16 +128,24 @@ class ProcessManager: # process (added with once()) if name in self.namemap: pi = self.namemap[name] + # the process will change its PID, so we delete it while we know it + del self.pidmap[pi.process.pid] pi.stop() pi.process.wait() pi.restart() + # add the new PID + self.pidmap[pi.process.pid] = pi + return True else: - self.services[name].start() + self.start(name) + return False def kill(self, name, signum): log.debug(u'ProcessManager.kill(%s, %s)', name, signum) - assert name in self.namemap - self.namemap[name].kill(name, stop) + if name in self.namemap: + self.namemap[name].kill(name, stop) + return True + return False def sigchild_handler(self, signum, stack_frame=None): log.debug(u'ProcessManager.sigchild_handler(%s)', signum) @@ -147,24 +167,25 @@ class ProcessManager: log.debug(u'ProcessManager.sigchild_handler: ' u'calling %s(%s)', p.callback.__name__, p) p.callback(self, p) - if p._dont_run or not p.persist or p.error_count >= p.max_errors: + if (p._dont_run or not p.persist + or p._error_count >= p.max_errors): log.debug(u"ProcessManager.sigchild_handler: can't " u'persist, dont_run=%s, persist=%s, error_cout=%s, ' u'max_errors=%s', p._dont_run, p.persist, - p.error_count, p.max_errors) + p._error_count, p.max_errors) del self.namemap[p.name] del self.pidmap[pid] p.clear() else: log.debug(u'ProcessManager.sigchild_handler: persist') if p.process.returncode == 0: - p.error_count = 0 + p._error_count = 0 log.debug(u'ProcessManager.sigchild_handler: ' u'return OK, resetting error_count') else: - p.error_count += 1 + p._error_count += 1 log.debug(u'ProcessManager.sigchild_handler: return' - u'not 0, error_count + 1 = %s', p.error_count) + u'not 0, error_count + 1 = %s', p._error_count) del self.pidmap[pid] p.restart() self.pidmap[p.process.pid] = p @@ -185,6 +206,8 @@ class ProcessManager: if name in self.pidmap: return self.pidmap[name] raise KeyError, name + # Syntax sugar for self[name] + __getitem__ = get def has(self, name): if isinstance(name, basestring): # is a name @@ -196,12 +219,8 @@ class ProcessManager: if name in self.pidmap: return True return False - - def __getitem__(self, name): - return self.get(name) - - def __contains__(self, name): - return self.has(name) + # Syntax sugar for name in self + __contains__ = has if __name__ == '__main__': @@ -257,6 +276,9 @@ if __name__ == '__main__': assert 'test-service' in manager.services assert 'test-service' not in manager.namemap assert not get('test-service').running + assert manager['test-service'] == get('test-service') + assert has('test-service') + assert 'test-service' in manager register('test-service-2', ('sleep', '3'), notify, False) assert 'test-service-2' in manager.services @@ -269,10 +291,20 @@ if __name__ == '__main__': assert 'test-once' not in manager.services assert 'test-once' in manager.namemap assert get('test-once').running + assert get('test-once').process.pid + pid = get('test-once').process.pid + restart('test-once') + assert pid != get('test-once').process.pid + assert pid != manager.pidmap[get('test-once').process.pid].process.pid start('test-service') assert 'test-service' in manager.namemap assert get('test-service').running + assert get('test-service').process.pid + pid = get('test-service').process.pid + restart('test-service') + assert pid != get('test-service').process.pid + assert pid != manager.pidmap[get('test-service').process.pid].process.pid print "Known processes:", manager.services.keys() print "Waiting...", manager.namemap.keys() @@ -290,8 +322,12 @@ if __name__ == '__main__': assert 'test-once' not in manager.services assert 'test-once' not in manager.namemap + restart('test-service') + assert get('test-service').process.pid + assert manager.pidmap[get('test-service').process.pid].process.pid + once('test-wait', ('sleep', '2')) - print 'test-wait returned?', get('test-wait').process.poll() + print 'test-wait running?', get('test-wait').running assert get('test-wait').running print 'Waiting test-wait to return...' ret = get('test-wait').process.wait()