X-Git-Url: https://git.llucax.com/software/sercom.git/blobdiff_plain/081f501efd6fd1c2833faafb45ed4f57fa4bb8c8..2c735b7a3859c99955e227e750d6fd2b169afce1:/sercom/subcontrollers/docente/__init__.py

diff --git a/sercom/subcontrollers/docente/__init__.py b/sercom/subcontrollers/docente/__init__.py
index c4dcfc5..d7d58bc 100644
--- a/sercom/subcontrollers/docente/__init__.py
+++ b/sercom/subcontrollers/docente/__init__.py
@@ -2,19 +2,24 @@
 
 from turbogears import controllers, expose, redirect
 from turbogears import validate, validators, flash, error_handler
-from sercom.model import Docente
 from turbogears.widgets import *
 from turbogears import identity
 from turbogears import paginate
 from docutils.core import publish_parts
+from sercom.subcontrollers import validate as val
+from sercom.model import Docente
 
 cls = Docente
 name = 'docente'
 namepl = name + 's'
 
+def validate_get(id): return val.validate_get(cls, name, id)
+def validate_set(id, data): return val.validate_set(cls, name, id, data)
+def validate_new(data): return val.validate_new(cls, name, data)
+
 form = TableForm(fields=[
     TextField(name='usuario', label=_(u'Usuario'),
-        help_text=_(u'Requerido.'),
+        help_text=_(u'Requerido y único.'),
         validator=validators.UnicodeString(min=3, max=10, strip=True)),
     TextField(name='nombre', label=_(u'Nombre'),
         help_text=_(u'Requerido.'),
@@ -51,23 +56,25 @@ class DocenteController(controllers.Controller, identity.SecureResource):
     def index(self):
         raise redirect('list')
 
-    @expose(template='kid:sercom.subcontrollers.%s.templates.list' % name)
+    @expose(template='kid:%s.templates.list' % __name__)
     @paginate('records')
     def list(self, **kw):
         """List records in model"""
         f = kw.get('tg_flash', None)
         r = cls.select()
-
         return dict(records=r, name=name, namepl=namepl, tg_flash=f)
 
     @expose()
     def activate(self, id, activo):
         """Save or create record to model"""
-        cls.get(int(id)).activo = int(activo)
-
+        r = validate_get(id)
+        try:
+            r.activo = bool(int(activo))
+        except ValueError, e:
+            raise redirect('../list', tg_flash=_(u'Acción inválida.'))
         raise redirect('../list')
 
-    @expose(template='kid:sercom.subcontrollers.%s.templates.new' % name)
+    @expose(template='kid:%s.templates.new' % __name__)
     def new(self, **kw):
         """Create new records in model"""
         f = kw.get('tg_flash', None)
@@ -78,49 +85,40 @@ class DocenteController(controllers.Controller, identity.SecureResource):
     @expose()
     def create(self, **kw):
         """Save or create record to model"""
-        try:
-            Docente(**kw)
-        except Exception, e:
-            raise redirect('new', tg_flash=_(u'No se pudo crear el nuevo %s, ' \
-                'probablemente ya existe uno con el mismo usuario (error: %s).'
-                    % (name, e)), **kw)
-
+        validate_new(kw)
         raise redirect('list', tg_flash=_(u'Se creó un nuevo %s.') % name)
 
-    @expose(template='kid:sercom.subcontrollers.%s.templates.edit' % name)
+    @expose(template='kid:%s.templates.edit' % __name__)
     def edit(self, id, **kw):
         """Edit record in model"""
-        try:
-            r = cls.get(int(id))
-        except LookupError:
-            flash = _('No existe el docente con identificador %d.') % id
-
-        return dict(name=name, namepl=namepl, record=r, form=form)
+        r = validate_get(id)
+        return dict(name=name, namepl=namepl, record=r, form=form,
+            tg_flash=kw.get('tg_flash', None))
 
     @validate(form=form)
     @error_handler(edit)
     @expose()
     def update(self, id, **kw):
         """Save or create record to model"""
-        record = cls.get(int(id))
-        record.set(**kw)
-
+        r = validate_set(id, kw)
         raise redirect('../list',
             tg_flash=_(u'El %s fue actualizado.') % name)
 
-    @expose(template='kid:sercom.subcontrollers.%s.templates.show' % name)
+    @expose(template='kid:%s.templates.show' % __name__)
     def show(self,id, **kw):
         """Show record in model"""
-        r = cls.get(int(id))
-        r.obs = publish_parts(r.observaciones, writer_name='html')['html_body']
-
+        r = validate_get(id)
+        if r.observaciones is None:
+            r.obs = ''
+        else:
+            r.obs = publish_parts(r.observaciones, writer_name='html')['html_body']
         return dict(name=name, namepl=namepl, record=r)
 
     @expose()
     def delete(self, id):
         """Destroy record in model"""
-        cls.delete(int(id))
-
+        r = validate_get(id)
+        r.destroySelf()
         raise redirect('../list',
             tg_flash=_(u'El %s fue eliminado permanentemente.') % name)