Mini bugfix.

[z.facultad/75.42/plaqui.git] / Server / src / controlserver.cpp

diff --git a/Server/src/controlserver.cpp b/Server/src/controlserver.cpp
index 348d77265c1ea4b177765328c6e7fc232aa7a2b9..a8baf506f296449bbada484efb8afd75d6ecec44 100644 (file)
--- a/Server/src/controlserver.cpp
+++ b/Server/src/controlserver.cpp
@@ -26,10 +26,11 @@
 //
 
 #include "plaqui/server/controlserver.h"
 //
 
 #include "plaqui/server/controlserver.h"

-#include "plaqui/server/httprequest.h"
-#include <cstring>
-#include <sstream>
+#include "plaqui/server/command.h"
+#include "plaqui/server/httperror.h"
+#include "plaqui/server/httpresponse.h"

 #ifdef DEBUG
 #ifdef DEBUG

+#      include "plaqui/server/string.h"

 #      include <iostream>
 #endif // DEBUG
 
 #      include <iostream>
 #endif // DEBUG
 


@@ -41,114 +42,81 @@ namespace Server {
 
 ControlServer::~ControlServer(void) {
 #ifdef DEBUG
 
 ControlServer::~ControlServer(void) {
 #ifdef DEBUG

-       cerr << __FILE__ << ": destructor." << endl;
+       cerr << __FILE__ << "(" << __LINE__ << ")"
+               << ": destructor." << endl;

 #endif // DEBUG
 }
 
 ControlServer::ControlServer(const sockbuf::sockdesc& sd):
 #endif // DEBUG
 }
 
 ControlServer::ControlServer(const sockbuf::sockdesc& sd):

-               ServerConnection(sd) {
+               Connection(sd) {

 #ifdef DEBUG
 #ifdef DEBUG

-       cerr << __FILE__ << ": sd = " << sd.sock << endl;
+       cerr << __FILE__ << "(" << __LINE__ << ")"
+               << ": sd = " << sd.sock << endl;

 #endif // DEBUG
 }
 
 #endif // DEBUG
 }
 

-void ControlServer::real_run(void) {
+void ControlServer::real_run(void) throw() {

 #ifdef DEBUG
 #ifdef DEBUG

-       cerr << __FILE__ << ": real_run()" << endl;
+       cerr << __FILE__ << "(" << __LINE__ << ")"
+               << ": real_run()" << endl;

 #endif // DEBUG
 #endif // DEBUG

-       char buf[BUFSIZ];
-       while (!stop) {
-               HTTPRequest request;
-               socket >> request;
-               // TODO agregar las verificaciones de abajo a HTTPRequest y padres.
-/*
-               // Primera línea no vacía (que debe ser el request).
-               bool is_first = true;
-               while (!stop && socket.getline(buf, BUFSIZ)) {
+       while (!stop()) {
+               Command command;
+               try {
+                       socket >> command;
+               } catch (const ios::failure& e) {
+                       // TODO poner buenos codigos de error.
+                       signal_error().emit(200000, "Se desconectó.");
+                       return;
+               } catch (const sockerr& e) {
+                       signal_error().emit(e.serrno(), e.errstr());
+                       return;
+               // Si hay un error al parsear el comando, se envia una respuesta con el
+               // error.
+               } catch (const HTTPError& e) {

 #ifdef DEBUG
 #ifdef DEBUG

-                       cerr << __FILE__ << "  Recibiendo inea: " << buf << endl;
+                       cerr << __FILE__ << "(" << __LINE__ << ")"
+                               << " : real_run() ERROR: status_code = "
+                               << e.code << " | reason = " << HTTPMessage::reason(e.code)
+                               << " | desc = " << e.what() << endl;

 #endif // DEBUG
 #endif // DEBUG

-                       int len = strlen(buf);
-                       // Si tiene un retorno de carro, lo elimina.
-                       if (len && (buf[len-1] == '\r')) {
-                               buf[--len] = '\0';
-                       }
-                       // Si tiene contenido, lo agrego a la información del request.
-                       if (len) {
-                               // Si es la primera línea, es el request.
-                               if (is_first) {
-                                       request.set_request(buf, socket->peerhost(),
-                                                       socket->peerport());
-                                       is_first = false;
-                               } else {
-                                       // TODO request.parse_header(buf);
-                               }
-                       // Si viene la línea vacía
-                       } else {
-                               // Si no es la primera, terminan las cabeceras HTTP.
-                               if (!is_first) {
-                                       // Podría ir un break.
-                                       stop = true;
-                                       continue;
-                               }
-                               // Si es la primera, no pasa nada, sigue esperando un request.
-                       }
+                       socket << HTTPResponse(e) << flush;
+                       continue;

                }
                }

-*/
-               // TODO: Manda el comando.
-               // Command command = parse_command(request.uri);
-               //signal_command_received().emit(command);

 #ifdef DEBUG
 #ifdef DEBUG

-               cerr << "Request: " << endl;
-               for (Request::const_iterator i = request.begin(); i != request.end();
-                               i++) {
-                       cerr << "   " << i->first << ": " << i->second << endl;
-               }
+               cerr << __FILE__ << "(" << __LINE__ << ")"
+                       << " : real_run() Despachando comando: target = "
+                       << command.get_target() << " | command = " << command.get_command()
+                       << " | args = [" << String::join(command.get_args(), ", ") << "]"
+                       << endl;

 #endif // DEBUG
 #endif // DEBUG

-               // FIXME - hacer respuesta XML.
-               // La respuesta hay que mandarla asincrónicamente porque no puedo
-               // responder hasta que la planta no se termine de actualizar, por
-               // ejemplo.
-               stringstream response_xml;
-               socket << "HTTP/1.0 200 OK" << endl;
-/*
-Date: Sun, 19 Oct 2003 15:11:14 GMT
-Server: Apache/1.3.28 (Debian GNU/Linux)
-Last-Modified: Mon, 28 Apr 2003 07:50:08 GMT
-Accept-Ranges: bytes
-*/
-               socket << "Content-Type: text/html; charset=iso-8859-1" << endl;
-               response_xml << "<html>" << endl;
-               response_xml << "    <head>" << endl;
-               response_xml << "        <title>PlaQui v0.1</title>" << endl;
-               response_xml << "    </head>" << endl;
-               response_xml << "    <body>" << endl;
-               response_xml << "        <h1>PlaQui</h1>" << endl;
-               response_xml << "        <p>versión 0.2</p>" << endl;
-               response_xml << "        <h2>Pedido HTTP</h2>" << endl;
-               response_xml << "        <ul>" << endl;
-               for (Request::const_iterator i = request.begin(); i != request.end();
-                               i++) {
-                       response_xml << "           <li><b>" << i->first << ":</b> "
-                               << i->second << endl;
-               }
-               response_xml << "        </ul>" << endl;
-               response_xml << "        <h2>Desarrollado por</h2>" << endl;
-               response_xml << "        <ul>" << endl;
-               response_xml << "            <li>Nicolás Dimov.</li>" << endl;
-               response_xml << "            <li>Leandro Lucarella.</li>" << endl;
-               response_xml << "            <li>Ricardo Markiewicz.</li>" << endl;
-               response_xml << "        </ul>" << endl;
-               response_xml << "        <address>" << endl;
-               response_xml << "             Copyleft 2003 - bajo los " << endl;
-               response_xml << "             términos de la licencia GPL" << endl;
-               response_xml << "        </address>" << endl;
-               response_xml << "    </body>" << endl;
-               response_xml << "</html>" << endl;
-               socket << "Content-Length: " << response_xml.str().length() << endl;
-               socket << endl;
-               socket << response_xml.str() << flush;
+               // Manda el comando.
+               command_received(command);
+       }
+}
+
+void ControlServer::send(const Response& response) {
+       try {
+               socket << response << flush;
+       } catch (const sockerr& e) {
+               cerr << __FILE__ << "(" << __LINE__ << ") send(): "
+                       << "Socket Error: " << e.operation() << " | serrno = "
+                       << e.serrno() << " | errstr = " << e.errstr() << endl;
+       } catch (const exception& e) {
+               cerr << __FILE__ << "(" << __LINE__ << ") send(): "
+                       << "Error: " << e.what() << endl;
+       } catch (...) {
+               cerr << __FILE__ << "(" << __LINE__ << ") send(): "
+                       << "Error DESCONOCIDO!!!!!!!!" << endl;

        }
        }

+#ifdef DEBUG
+       cerr << __FILE__ << "(" << __LINE__ << ")"
+               << ": send() Enviado!" << endl;
+#endif // DEBUG
+}
+
+ControlServer::SignalCommandReceived& ControlServer::signal_command_received(void) {
+       return command_received;

 }
 
 } // namespace Server
 }
 
 } // namespace Server