Hacer funciones de validación más legibles.

[z.facultad/75.52/sercom.git] / sercom / subcontrollers / docente / __init__.py

diff --git a/sercom/subcontrollers/docente/__init__.py b/sercom/subcontrollers/docente/__init__.py
index c410e4d7fd72578c41d800de7dba96f558fd7292..12fd14709e8e4213635eb99eec6310204626f414 100644 (file)
--- a/sercom/subcontrollers/docente/__init__.py
+++ b/sercom/subcontrollers/docente/__init__.py
@@ -1,20 +1,38 @@
-# vim: set et sw=4 sts=4 encoding=utf-8 :
+# vim: set et sw=4 sts=4 encoding=utf-8 foldmethod=marker :

 
 

+#{{{ Imports
+import cherrypy

 from turbogears import controllers, expose, redirect
 from turbogears import validate, validators, flash, error_handler
 from turbogears import controllers, expose, redirect
 from turbogears import validate, validators, flash, error_handler

-from sercom.model import Docente

 from turbogears.widgets import *
 from turbogears import identity
 from turbogears import paginate
 from docutils.core import publish_parts
 from turbogears.widgets import *
 from turbogears import identity
 from turbogears import paginate
 from docutils.core import publish_parts

+from sercom.subcontrollers import validate as val
+from sercom.model import Docente
+#}}}

 
 

+#{{{ Configuración

 cls = Docente
 name = 'docente'
 namepl = name + 's'
 cls = Docente
 name = 'docente'
 namepl = name + 's'

+#}}}
+
+#{{{ Validación
+def validate_get(id):
+    return val.validate_get(cls, name, id)
+
+def validate_set(id, data):
+    return val.validate_set(cls, name, id, data)

 
 

+def validate_new(data):
+    return val.validate_new(cls, name, data)
+#}}}
+
+#{{{ Formulario

 form = TableForm(fields=[
     TextField(name='usuario', label=_(u'Usuario'),
 form = TableForm(fields=[
     TextField(name='usuario', label=_(u'Usuario'),

-        help_text=_(u'Requerido.'),
+        help_text=_(u'Requerido y único.'),

         validator=validators.UnicodeString(min=3, max=10, strip=True)),
     TextField(name='nombre', label=_(u'Nombre'),
         help_text=_(u'Requerido.'),
         validator=validators.UnicodeString(min=3, max=10, strip=True)),
     TextField(name='nombre', label=_(u'Nombre'),
         help_text=_(u'Requerido.'),


@@ -37,7 +55,10 @@ form = TableForm(fields=[
         #help_text=_(u'Si no está activo no puede ingresar al sistema.'),
         validator=validators.Bool(if_empty=1)),
 ])
         #help_text=_(u'Si no está activo no puede ingresar al sistema.'),
         validator=validators.Bool(if_empty=1)),
 ])

+form.javascript.append(JSSource("MochiKit.DOM.focusOnLoad('form_usuario');"))
+#}}}

 
 

+#{{{ Controlador

 class DocenteController(controllers.Controller, identity.SecureResource):
     """Basic model admin interface"""
     require = identity.has_permission('admin')
 class DocenteController(controllers.Controller, identity.SecureResource):
     """Basic model admin interface"""
     require = identity.has_permission('admin')


@@ -51,37 +72,41 @@ class DocenteController(controllers.Controller, identity.SecureResource):
     def index(self):
         raise redirect('list')
 
     def index(self):
         raise redirect('list')
 

-    @expose(template='kid:sercom.subcontrollers.%s.templates.list' % name)
+    @expose(template='kid:%s.templates.list' % __name__)

     @paginate('records')
     @paginate('records')

-    def list(self, **kw):
+    def list(self):

         """List records in model"""
         """List records in model"""

-        f = kw.get('tg_flash', None)

         r = cls.select()
         r = cls.select()

+        return dict(records=r, name=name, namepl=namepl)

 
 

-        return dict(records=r, name=name, namepl=namepl, tg_flash=f)
+    @expose()
+    def activate(self, id, activo):
+        """Save or create record to model"""
+        r = validate_get(id)
+        try:
+            r.activo = bool(int(activo))
+        except ValueError:
+            raise cherrypy.NotFound
+        raise redirect('../../list')

 
 

-    @expose(template='kid:sercom.subcontrollers.%s.templates.new' % name)
+    @expose(template='kid:%s.templates.new' % __name__)

     def new(self, **kw):
         """Create new records in model"""
     def new(self, **kw):
         """Create new records in model"""

-        return dict(name=name, namepl=namepl, form=form)
+        return dict(name=name, namepl=namepl, form=form, values=kw)

 
     @validate(form=form)
     @error_handler(new)
     @expose()
     def create(self, **kw):
         """Save or create record to model"""
 
     @validate(form=form)
     @error_handler(new)
     @expose()
     def create(self, **kw):
         """Save or create record to model"""

-        Docente(**kw)
-
-        raise redirect('list', tg_flash=_(u'Se creó un nuevo %s.') % name)
+        validate_new(kw)
+        flash(_(u'Se creó un nuevo %s.') % name)
+        raise redirect('list')

 
 

-    @expose(template='kid:sercom.subcontrollers.%s.templates.edit' % name)
+    @expose(template='kid:%s.templates.edit' % __name__)

     def edit(self, id, **kw):
         """Edit record in model"""
     def edit(self, id, **kw):
         """Edit record in model"""

-        try:
-            r = cls.get(int(id))
-        except LookupError:
-            flash = _('No existe el docente con identificador %d.') % id
-
+        r = validate_get(id)

         return dict(name=name, namepl=namepl, record=r, form=form)
 
     @validate(form=form)
         return dict(name=name, namepl=namepl, record=r, form=form)
 
     @validate(form=form)


@@ -89,25 +114,26 @@ class DocenteController(controllers.Controller, identity.SecureResource):
     @expose()
     def update(self, id, **kw):
         """Save or create record to model"""
     @expose()
     def update(self, id, **kw):
         """Save or create record to model"""

-        record = cls.get(int(id))
-        record.set(**kw)
-
-        raise redirect('../list',
-            tg_flash=_(u'El %s fue actualizado.') % name)
+        r = validate_set(id, kw)
+        flash(_(u'El %s fue actualizado.') % name)
+        raise redirect('../list')

 
 

-    @expose(template='kid:sercom.subcontrollers.%s.templates.show' % name)
+    @expose(template='kid:%s.templates.show' % __name__)

     def show(self,id, **kw):
         """Show record in model"""
     def show(self,id, **kw):
         """Show record in model"""

-        r = cls.get(int(id))
-        r.obs = publish_parts(r.observaciones, writer_name='html')['html_body']
-
+        r = validate_get(id)
+        if r.observaciones is None:
+            r.obs = ''
+        else:
+            r.obs = publish_parts(r.observaciones, writer_name='html')['html_body']

         return dict(name=name, namepl=namepl, record=r)
 
     @expose()
     def delete(self, id):
         """Destroy record in model"""
         return dict(name=name, namepl=namepl, record=r)
 
     @expose()
     def delete(self, id):
         """Destroy record in model"""

-        cls.delete(int(id))
-
-        raise redirect('../list',
-            tg_flash=_(u'El %s fue eliminado permanentemente.') % name)
+        r = validate_get(id)
+        r.destroySelf()
+        flash(_(u'El %s fue eliminado permanentemente.') % name)
+        raise redirect('../list')
+#}}}