avoid backend_modify call unless ev_io_set was used

[software/libev.git] / ev_poll.c

diff --git a/ev_poll.c b/ev_poll.c
index 0af63f3a3afceb04bc9b0f31256f931105e20258..d609833e291e21f40d91846ddc9e6b7e0f8269b2 100644 (file)
--- a/ev_poll.c
+++ b/ev_poll.c
@@ -1,5 +1,5 @@
 /*
 /*

- * libev epoll fd activity backend
+ * libev poll fd activity backend

  *
  * Copyright (c) 2007 Marc Alexander Lehmann <libev@schmorp.de>
  * All rights reserved.
  *
  * Copyright (c) 2007 Marc Alexander Lehmann <libev@schmorp.de>
  * All rights reserved.


@@ -31,12 +31,7 @@
 
 #include <poll.h>
 
 
 #include <poll.h>
 

-static struct pollfd *polls;
-static int pollmax, pollcnt;
-static int *pollidxs; /* maps fds into structure indices */
-static int pollidxmax;
-
-static void
+void inline_size

 pollidx_init (int *base, int count)
 {
   while (count--)
 pollidx_init (int *base, int count)
 {
   while (count--)


@@ -44,29 +39,36 @@ pollidx_init (int *base, int count)
 }
 
 static void
 }
 
 static void

-poll_modify (int fd, int oev, int nev)
+poll_modify (EV_P_ int fd, int oev, int nev)

 {
   int idx;
 {
   int idx;

-  array_needsize (pollidxs, pollidxmax, fd + 1, pollidx_init);
+
+  if (oev == nev)
+    return;
+
+  array_needsize (int, pollidxs, pollidxmax, fd + 1, pollidx_init);

 
   idx = pollidxs [fd];
 
   if (idx < 0) /* need to allocate a new pollfd */
     {
 
   idx = pollidxs [fd];
 
   if (idx < 0) /* need to allocate a new pollfd */
     {

-      idx = pollcnt++;
-      array_needsize (polls, pollmax, pollcnt, );
+      pollidxs [fd] = idx = pollcnt++;
+      array_needsize (struct pollfd, polls, pollmax, pollcnt, EMPTY2);

       polls [idx].fd = fd;
     }
 
       polls [idx].fd = fd;
     }
 

+  assert (polls [idx].fd == fd);
+

   if (nev)
     polls [idx].events =
         (nev & EV_READ ? POLLIN : 0)
         | (nev & EV_WRITE ? POLLOUT : 0);
   else /* remove pollfd */
     {
   if (nev)
     polls [idx].events =
         (nev & EV_READ ? POLLIN : 0)
         | (nev & EV_WRITE ? POLLOUT : 0);
   else /* remove pollfd */
     {

-      if (idx < pollcnt--)
+      pollidxs [fd] = -1;
+
+      if (expect_true (idx < --pollcnt))

         {
         {

-          pollidxs [fd] = -1;

           polls [idx] = polls [pollcnt];
           pollidxs [polls [idx].fd] = idx;
         }
           polls [idx] = polls [pollcnt];
           pollidxs [polls [idx].fd] = idx;
         }


@@ -74,35 +76,52 @@ poll_modify (int fd, int oev, int nev)
 }
 
 static void
 }
 
 static void

-poll_poll (ev_tstamp timeout)
+poll_poll (EV_P_ ev_tstamp timeout)

 {
 {

-  int res = poll (polls, pollcnt, ceil (timeout * 1000.));
+  int i;
+  int res = poll (polls, pollcnt, (int)ceil (timeout * 1000.));

 
 

-  if (res > 0)
-    {
-      int i;
-
-      for (i = 0; i < pollcnt; ++i)
-        fd_event (
-          polls [i].fd,
-          (polls [i].revents & (POLLOUT | POLLERR | POLLHUP) ? EV_WRITE : 0)
-          | (polls [i].revents & (POLLIN | POLLERR | POLLHUP) ? EV_READ : 0)
-        );
-    }
-  else if (res < 0)
+  if (expect_false (res < 0))

     {
       if (errno == EBADF)
     {
       if (errno == EBADF)

-        fd_ebadf ();
-      else if (errno == ENOMEM)
-        fd_enomem ();
+        fd_ebadf (EV_A);
+      else if (errno == ENOMEM && !syserr_cb)
+        fd_enomem (EV_A);
+      else if (errno != EINTR)
+        syserr ("(libev) poll");
+
+      return;

     }
     }

+
+  for (i = 0; i < pollcnt; ++i)
+    if (expect_false (polls [i].revents & POLLNVAL))
+      fd_kill (EV_A_ polls [i].fd);
+    else
+      fd_event (
+        EV_A_
+        polls [i].fd,
+        (polls [i].revents & (POLLOUT | POLLERR | POLLHUP) ? EV_WRITE : 0)
+        | (polls [i].revents & (POLLIN | POLLERR | POLLHUP) ? EV_READ : 0)
+      );

 }
 
 }
 

-static void
-poll_init (int flags)
+int inline_size
+poll_init (EV_P_ int flags)
+{
+  backend_fudge  = 0.; /* posix says this is zero */
+  backend_modify = poll_modify;
+  backend_poll   = poll_poll;
+
+  pollidxs = 0; pollidxmax = 0;
+  polls    = 0; pollmax    = 0; pollcnt = 0;
+
+  return EVBACKEND_POLL;
+}
+
+void inline_size
+poll_destroy (EV_P)

 {
 {

-  ev_method     = EVMETHOD_POLL;
-  method_fudge  = 1e-3; /* needed to compensate for select returning early, very conservative */
-  method_modify = poll_modify;
-  method_poll   = poll_poll;
+  ev_free (pollidxs);
+  ev_free (polls);

 }
 }

+