fix stop function of idle/check/prepare/child

[software/libev.git] / ev.c

diff --git a/ev.c b/ev.c
index 28ed91b2ac61771d97f8f229f668b72594e7c46a..5aca9ec075bf9359501dd6cb2cf7645366049a8c 100644 (file)
--- a/ev.c
+++ b/ev.c
@@ -251,7 +251,7 @@ typedef struct
 
 /*****************************************************************************/
 
 
 /*****************************************************************************/
 

-inline ev_tstamp
+ev_tstamp

 ev_time (void)
 {
 #if EV_USE_REALTIME
 ev_time (void)
 {
 #if EV_USE_REALTIME


@@ -806,7 +806,9 @@ loop_destroy (EV_P)
   /* have to use the microsoft-never-gets-it-right macro */
   array_free_microshit (fdchange);
   array_free_microshit (timer);
   /* have to use the microsoft-never-gets-it-right macro */
   array_free_microshit (fdchange);
   array_free_microshit (timer);

+#if EV_PERIODICS

   array_free_microshit (periodic);
   array_free_microshit (periodic);

+#endif

   array_free_microshit (idle);
   array_free_microshit (prepare);
   array_free_microshit (check);
   array_free_microshit (idle);
   array_free_microshit (prepare);
   array_free_microshit (check);


@@ -989,7 +991,11 @@ timers_reify (EV_P)
       if (w->repeat)
         {
           assert (("negative ev_timer repeat value found while processing timers", w->repeat > 0.));
       if (w->repeat)
         {
           assert (("negative ev_timer repeat value found while processing timers", w->repeat > 0.));

-          ((WT)w)->at = mn_now + w->repeat;
+
+          ((WT)w)->at += w->repeat;
+          if (((WT)w)->at < mn_now)
+            ((WT)w)->at = mn_now;
+

           downheap ((WT *)timers, timercnt, 0);
         }
       else
           downheap ((WT *)timers, timercnt, 0);
         }
       else


@@ -999,6 +1005,7 @@ timers_reify (EV_P)
     }
 }
 
     }
 }
 

+#if EV_PERIODICS

 static void
 periodics_reify (EV_P)
 {
 static void
 periodics_reify (EV_P)
 {


@@ -1049,6 +1056,7 @@ periodics_reschedule (EV_P)
   for (i = periodiccnt >> 1; i--; )
     downheap ((WT *)periodics, periodiccnt, i);
 }
   for (i = periodiccnt >> 1; i--; )
     downheap ((WT *)periodics, periodiccnt, i);
 }

+#endif

 
 inline int
 time_update_monotonic (EV_P)
 
 inline int
 time_update_monotonic (EV_P)


@@ -1092,7 +1100,9 @@ time_update (EV_P)
               now_floor = mn_now;
             }
 
               now_floor = mn_now;
             }
 

+# if EV_PERIODICS

           periodics_reschedule (EV_A);
           periodics_reschedule (EV_A);

+# endif

           /* no timer adjustment, as the monotonic clock doesn't jump */
           /* timers_reschedule (EV_A_ rtmn_diff - odiff) */
         }
           /* no timer adjustment, as the monotonic clock doesn't jump */
           /* timers_reschedule (EV_A_ rtmn_diff - odiff) */
         }


@@ -1104,7 +1114,9 @@ time_update (EV_P)
 
       if (expect_false (mn_now > ev_rt_now || mn_now < ev_rt_now - MAX_BLOCKTIME - MIN_TIMEJUMP))
         {
 
       if (expect_false (mn_now > ev_rt_now || mn_now < ev_rt_now - MAX_BLOCKTIME - MIN_TIMEJUMP))
         {

+#if EV_PERIODICS

           periodics_reschedule (EV_A);
           periodics_reschedule (EV_A);

+#endif

 
           /* adjust timers. this is easy, as the offset is the same for all */
           for (i = 0; i < timercnt; ++i)
 
           /* adjust timers. this is easy, as the offset is the same for all */
           for (i = 0; i < timercnt; ++i)


@@ -1177,11 +1189,13 @@ ev_loop (EV_P_ int flags)
               if (block > to) block = to;
             }
 
               if (block > to) block = to;
             }
 

+#if EV_PERIODICS

           if (periodiccnt)
             {
               ev_tstamp to = ((WT)periodics [0])->at - ev_rt_now + method_fudge;
               if (block > to) block = to;
             }
           if (periodiccnt)
             {
               ev_tstamp to = ((WT)periodics [0])->at - ev_rt_now + method_fudge;
               if (block > to) block = to;
             }

+#endif

 
           if (block < 0.) block = 0.;
         }
 
           if (block < 0.) block = 0.;
         }


@@ -1193,7 +1207,9 @@ ev_loop (EV_P_ int flags)
 
       /* queue pending timers and reschedule them */
       timers_reify (EV_A); /* relative timers called last */
 
       /* queue pending timers and reschedule them */
       timers_reify (EV_A); /* relative timers called last */

+#if EV_PERIODICS

       periodics_reify (EV_A); /* absolute timers called first */
       periodics_reify (EV_A); /* absolute timers called first */

+#endif

 
       /* queue idle watchers unless io or timers are pending */
       if (idlecnt && !any_pending (EV_A))
 
       /* queue idle watchers unless io or timers are pending */
       if (idlecnt && !any_pending (EV_A))


@@ -1335,7 +1351,7 @@ ev_timer_stop (EV_P_ struct ev_timer *w)
       downheap ((WT *)timers, timercnt, ((W)w)->active - 1);
     }
 
       downheap ((WT *)timers, timercnt, ((W)w)->active - 1);
     }
 

-  ((WT)w)->at = w->repeat;
+  ((WT)w)->at -= mn_now;

 
   ev_stop (EV_A_ (W)w);
 }
 
   ev_stop (EV_A_ (W)w);
 }


@@ -1354,6 +1370,7 @@ ev_timer_again (EV_P_ struct ev_timer *w)
     ev_timer_start (EV_A_ w);
 }
 
     ev_timer_start (EV_A_ w);
 }
 

+#if EV_PERIODICS

 void
 ev_periodic_start (EV_P_ struct ev_periodic *w)
 {
 void
 ev_periodic_start (EV_P_ struct ev_periodic *w)
 {


@@ -1402,6 +1419,7 @@ ev_periodic_again (EV_P_ struct ev_periodic *w)
   ev_periodic_stop (EV_A_ w);
   ev_periodic_start (EV_A_ w);
 }
   ev_periodic_stop (EV_A_ w);
   ev_periodic_start (EV_A_ w);
 }

+#endif

 
 void
 ev_idle_start (EV_P_ struct ev_idle *w)
 
 void
 ev_idle_start (EV_P_ struct ev_idle *w)


@@ -1462,7 +1480,7 @@ void
 ev_check_stop (EV_P_ struct ev_check *w)
 {
   ev_clear_pending (EV_A_ (W)w);
 ev_check_stop (EV_P_ struct ev_check *w)
 {
   ev_clear_pending (EV_A_ (W)w);

-  if (ev_is_active (w))
+  if (!ev_is_active (w))

     return;
 
   checks [((W)w)->active - 1] = checks [--checkcnt];
     return;
 
   checks [((W)w)->active - 1] = checks [--checkcnt];


@@ -1533,7 +1551,7 @@ void
 ev_child_stop (EV_P_ struct ev_child *w)
 {
   ev_clear_pending (EV_A_ (W)w);
 ev_child_stop (EV_P_ struct ev_child *w)
 {
   ev_clear_pending (EV_A_ (W)w);

-  if (ev_is_active (w))
+  if (!ev_is_active (w))

     return;
 
   wlist_del ((WL *)&childs [w->pid & (PID_HASHSIZE - 1)], (WL)w);
     return;
 
   wlist_del ((WL *)&childs [w->pid & (PID_HASHSIZE - 1)], (WL)w);