Add more conservative GCC options to detect bugs

Also fix the code to compile with these new options.

diff --git a/src/Makefile b/src/Makefile
index 20c4ad355df13dd9d0a21317bf0fc12c748d6008..bf150396ff1751d0f07e5a8c157788e197be688e 100644 (file)
--- a/src/Makefile
+++ b/src/Makefile
@@ -2,7 +2,7 @@ OBJS=lib-display-blanking-status-menu-widget.o
 SOURCES=lib-display-blanking-status-menu-widget.c
 LIB=lib-displayblanking-status-menu.so
 PKG_FLAGS=$(shell pkg-config hildon-1 libhildondesktop-1 --libs --cflags)
 SOURCES=lib-display-blanking-status-menu-widget.c
 LIB=lib-displayblanking-status-menu.so
 PKG_FLAGS=$(shell pkg-config hildon-1 libhildondesktop-1 --libs --cflags)

-CCFLAGS=-shared
+CCFLAGS=-shared -Wall -Werror -pedantic -std=c99

 CC=gcc
 
 all:$(LIB)
 CC=gcc
 
 all:$(LIB)

diff --git a/src/lib-display-blanking-status-menu-widget.c b/src/lib-display-blanking-status-menu-widget.c
index 18beee5c4f3468a0c18deacff960bfc7248e8013..0f0f3f82921eda71bb76fa97c43b53750e83502a 100644 (file)
--- a/src/lib-display-blanking-status-menu-widget.c
+++ b/src/lib-display-blanking-status-menu-widget.c
@@ -21,6 +21,7 @@
 
 #include <stdio.h>
 #include <stdlib.h>
 
 #include <stdio.h>
 #include <stdlib.h>

+#include <string.h>

 #include <libintl.h>
 #include <gtk/gtk.h>
 #include <hildon/hildon.h>
 #include <libintl.h>
 #include <gtk/gtk.h>
 #include <hildon/hildon.h>


@@ -98,7 +99,7 @@ struct _DisplayBlankingStatusPluginPrivate
 };
 
 HD_DEFINE_PLUGIN_MODULE (DisplayBlankingStatusPlugin,
 };
 
 HD_DEFINE_PLUGIN_MODULE (DisplayBlankingStatusPlugin,

-        display_blanking_status_plugin, HD_TYPE_STATUS_MENU_ITEM);
+        display_blanking_status_plugin, HD_TYPE_STATUS_MENU_ITEM)

 
 static void
 display_blanking_status_plugin_class_finalize (
 
 static void
 display_blanking_status_plugin_class_finalize (


@@ -197,8 +198,8 @@ display_blanking_status_plugin_init (DisplayBlankingStatusPlugin *plugin)
     gconf_client_add_dir (priv->gconf_client, MODE_GCONF_ROOT,
             GCONF_CLIENT_PRELOAD_NONE, &error);
     g_assert (error == NULL);
     gconf_client_add_dir (priv->gconf_client, MODE_GCONF_ROOT,
             GCONF_CLIENT_PRELOAD_NONE, &error);
     g_assert (error == NULL);

-    gconf_client_notify_add (priv->gconf_client, MODE_GCONF_KEY, &on_gconf_notify,
-            priv, NULL, &error);
+    gconf_client_notify_add (priv->gconf_client, MODE_GCONF_KEY,
+            (GConfClientNotifyFunc) &on_gconf_notify, priv, NULL, &error);

     g_assert (error == NULL);
 
     gtk_container_add (GTK_CONTAINER (plugin), priv->button);
     g_assert (error == NULL);
 
     gtk_container_add (GTK_CONTAINER (plugin), priv->button);