Check for name uniqueness when a new process is added to ProcessManager.

This check is against both current running processes (namemap) and the
registered processes (services) to ensure that the name is unique and so
process gets overriden.

diff --git a/pymin/procman.py b/pymin/procman.py
index adfa792ca68be7ecc0c5f924fd7d8f76df17653b..4fc75a8949b3ad21adfe22ae1ce470c43123cce8 100644 (file)
--- a/pymin/procman.py
+++ b/pymin/procman.py
@@ -72,6 +72,7 @@ class ProcessManager:
                 max_errors=3, *args, **kwargs):
         log.debug(u'ProcessManager.register(%s, %s, %s, %s, %s, %s, %s)',
                   name, command, callback, persist, max_errors, args, kwargs)
                 max_errors=3, *args, **kwargs):
         log.debug(u'ProcessManager.register(%s, %s, %s, %s, %s, %s, %s)',
                   name, command, callback, persist, max_errors, args, kwargs)

+        assert not self.has(name)

         self.services[name] = ProcessInfo(name, command, callback, persist,
                                           max_errors, args, kwargs)
 
         self.services[name] = ProcessInfo(name, command, callback, persist,
                                           max_errors, args, kwargs)
 


@@ -87,6 +88,7 @@ class ProcessManager:
                 max_errors=3, *args, **kwargs):
         log.debug(u'ProcessManager.call(%s, %s, %s, %s, %s, %s, %s)',
                   name, command, callback, persist, max_errors, args, kwargs)
                 max_errors=3, *args, **kwargs):
         log.debug(u'ProcessManager.call(%s, %s, %s, %s, %s, %s, %s)',
                   name, command, callback, persist, max_errors, args, kwargs)

+        assert not self.has(name)

         pi = ProcessInfo(name, command, callback, persist, max_errors,
                          args, kwargs)
         self._call(pi)
         pi = ProcessInfo(name, command, callback, persist, max_errors,
                          args, kwargs)
         self._call(pi)